On Tue, Dec 17, 2019 at 05:12:05AM +0100, Miklos Szeredi wrote: > On Tue, Dec 17, 2019 at 4:37 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > On Thu, Nov 28, 2019 at 04:59:40PM +0100, Miklos Szeredi wrote: > > > While this is a standard option as documented in mount(8), it is ignored by > > > most filesystems. So reject, unless filesystem explicitly wants to handle > > > it. > > > > > > The exception is unconverted filesystems, where it is unknown if the > > > filesystem handles this or not. > > > > > > Any implementation, such as mount(8), that needs to parse this option > > > without failing can simply ignore the return value from fsconfig(). > > > > Unless I'm missing something, that will mean that having it in /etc/fstab > > for a converted filesystem (xfs, for example) will fail when booting > > new kernel with existing /sbin/mount. Doesn't sound like a good idea... > > Nope, the mount(2) case is not changed (see second hunk). How would mounting XFS end up calling legacy_parse_param(), rather than the expected generic_parse_monolithic() -> vfs_parse_fs_string() -> vfs_parse_fs_param() -> xfs_fc_parse_param()?
