On Sat, Nov 30, 2019 at 01:19:23PM -0800, James Bottomley wrote: > I had another look at what it would take to reimplement shiftfs as a > true bind mount. It turns out we do have struct path threaded in > almost enough places to make it work. There really is only one API > that needs updating and that's notify_change(), so the following patch > fixes that and pulls do_truncate() along as well. The updates are > mostly smooth and pretty obvious because the path was actually already > present, except for in overlayfs where trying to sort out what the path > should be is somewhat of a nightmare. If the overlayfs people could > take a look and make sure I got it right, I'd be grateful. > > I think this is the only needed change, but I've only just got a > functional implementation of a uid/gid shifting bind mount, so there > might be other places that need rethreading as I find deficiencies in > the current implementation. I'll send them along as additional patches > if I find them Thanks for the patch. Can you please make sure to Cc the following people who attended the dedicated shiftfs session together with you at LPC in Lisbon for v2? They're all major stackholders in this: Stéphane Graber <stgraber@xxxxxxxxxx> Eric Biederman <ebiederm@xxxxxxxxxxxx> David Howells <dhowells@xxxxxxxxxx> Aleksa Sarai <cyphar@xxxxxxxxxx> Christian Brauner <christian.brauner@xxxxxxxxxx> (I haven't gotten around to looking at the initial bind mount patchset you sent out about two weeks ago. Pre-holidays it's always tricky to find time for proper reviews...) Christian
