> > + /* Of the r and x bits, all (subject to umask) must be > > present.*/ > > + if ((perm & 0555) != (i_mode & 0555)) I modified it due to warnning alarm from checkpatch.pl. Other octal permissions are same reason. WARNING: Symbolic permissions 'S_IRUGO | S_IXUGO' are not preferred. Consider using octal permissions '0555'. + if ((perm & (S_IRUGO | S_IXUGO)) != (i_mode & (S_IRUGO | S_IXUGO))) > > + /* update the directory entry */ > > + if (!evict) { > > + es = exfat_get_dentry_set(sb, &(ei->dir), ei->entry, > > + ES_ALL_ENTRIES, &ep); > > + if (!es) > > + return -EIO; > > + ep2 = ep + 1; > > The ep2 could point out on the garbage here. Maybe, it makes sense to > add some check here? Could you please elaborate more? How could ep2 be the garbage? I want you to check exfat_get_dentry_set(). Thanks for your review!