Re: [PATCH] jbd2: fix kernel-doc notation warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun 08-12-19 20:31:32, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> 
> Fix kernel-doc warning by inserting a beginning '*' character
> for the kernel-doc line.
> 
> ../include/linux/jbd2.h:461: warning: bad line:         journal. These are dirty buffers and revoke descriptor blocks.
> 
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: "Theodore Ts'o" <tytso@xxxxxxx>
> Cc: Jan Kara <jack@xxxxxxxx>
> Cc: linux-ext4@xxxxxxxxxxxxxxx

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  include/linux/jbd2.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20191209.orig/include/linux/jbd2.h
> +++ linux-next-20191209/include/linux/jbd2.h
> @@ -457,7 +457,7 @@ struct jbd2_revoke_table_s;
>   * @h_journal: Which journal handle belongs to - used iff h_reserved set.
>   * @h_rsv_handle: Handle reserved for finishing the logical operation.
>   * @h_total_credits: Number of remaining buffers we are allowed to add to
> -	journal. These are dirty buffers and revoke descriptor blocks.
> + *	journal. These are dirty buffers and revoke descriptor blocks.
>   * @h_revoke_credits: Number of remaining revoke records available for handle
>   * @h_ref: Reference count on this handle.
>   * @h_err: Field for caller's use to track errors through large fs operations.
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux