From: Eric Biggers <ebiggers@xxxxxxxxxx> Make to_mnt_ns() static to address the following 'sparse' warning: fs/namespace.c:1731:22: warning: symbol 'to_mnt_ns' was not declared. Should it be static? Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> --- Hi Andrew, please consider applying this straightforward cleanup. This has been sent to Al four times with no response, plus this same patch has been sent many times by other people too. fs/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namespace.c b/fs/namespace.c index 2fd0c8bcb8c14..dd26cad6c5dd5 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -1728,7 +1728,7 @@ static bool is_mnt_ns_file(struct dentry *dentry) dentry->d_fsdata == &mntns_operations; } -struct mnt_namespace *to_mnt_ns(struct ns_common *ns) +static struct mnt_namespace *to_mnt_ns(struct ns_common *ns) { return container_of(ns, struct mnt_namespace, ns); } -- 2.24.0.393.g34dc348eaf-goog