Re: [RFC PATCH v4 01/22] bootconfig: Add Extra Boot Config support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 12/2/19 2:13 AM, Masami Hiramatsu wrote:
> diff --git a/init/Kconfig b/init/Kconfig
> index 67a602ee17f1..13bb3eac804c 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1235,6 +1235,17 @@ source "usr/Kconfig"
>  
>  endif
>  
> +config BOOT_CONFIG
> +	bool "Boot config support"
> +	select LIBXBC
> +	default y

questionable "default y".
That needs lots of justification.

> +	help
> +	 Extra boot config allows system admin to pass a config file as
> +	 complemental extension of kernel cmdline when boot.

	                                          when booting.

> +	 The boot config file is usually attached at the end of initramfs.

The 3 help text lines above should be indented with one tab + 2 spaces,
like the "If" line below.

> +
> +	  If unsure, say Y.
> +
>  choice
>  	prompt "Compiler optimization level"
>  	default CC_OPTIMIZE_FOR_PERFORMANCE


-- 
~Randy




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux