On Thu, Dec 5, 2019 at 2:30 PM David Howells <dhowells@xxxxxxxxxx> wrote: > > - struct pipe_buffer *buf = &pipe->bufs[(head - 1) & mask]; > + struct pipe_buffer *buf = > + &pipe->bufs[(head - 1) & (pipe->ring_size - 1)]; I changed the two occurrences of this to use a local temporary "mask" variable, to avoid the long lines. It's no longer _caching_ the value, but it makes the code more legible. Linus