On Thu, Dec 05, 2019 at 09:33:46AM -0800, Christoph Hellwig wrote: > On Thu, Dec 05, 2019 at 06:32:42PM +0100, Johannes Thumshirn wrote: > > Meaning we do not need to export generic_file_buffered_read() and still can > > skip the generic DIO madness. > > But why not export it? That way we call the function we want directly > instead of through a wrapper that is entirely pointless for this case. To hide the implementation details and not provoke someone yelling layering violation?