While the patch itself looks fine, I kinda disagree with the rationale. If we want different ops for DAX that applies to file operations just as much as to the address space operations. However I agree that the ops are logically a better fit for the file operations, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx>