On Thu, 14 Nov 2019 at 12:05, Hou Tao <houtao1@xxxxxxxxxx> wrote: > > Hi, > > On 2019/11/14 4:38, Han Xu wrote: > > Tested the JFFS2 on 5.4 kernel as the instruction said, still got some > > errors, any ideas? > > > > > > > With the patch, > > > > root@imx8mmevk:~# cat /proc/mtd > > dev: size erasesize name > > mtd0: 00400000 00020000 "mtdram test device" > > mtd1: 04000000 00020000 "5d120000.spi" > > root@imx8mmevk:~# mtd_debug info /dev/mtd0 > > mtd.type = MTD_RAM > > mtd.flags = MTD_CAP_RAM > > mtd.size = 4194304 (4M) > > mtd.erasesize = 131072 (128K) > > mtd.writesize = 1 > > mtd.oobsize = 0 > > regions = 0 > > > > root@imx8mmevk:~# flash_erase /dev/mtd0 0 0 > > Erasing 128 Kibyte @ 3e0000 -- 100 % complete > > root@imx8mmevk:~# mount -t jffs2 /dev/mtdblock0 test_dir/ > > root@imx8mmevk:~# mount > > /dev/mtdblock0 on /home/root/test_dir type jffs2 (rw,relatime) > > > > BUT, it's not writable. > > You should revert the following commit to make it work: > > commit f2538f999345405f7d2e1194c0c8efa4e11f7b3a > Author: Jia-Ju Bai <baijiaju1990@xxxxxxxxx> > Date: Wed Jul 24 10:46:58 2019 +0800 > > jffs2: Fix possible null-pointer dereferences in jffs2_add_frag_to_fragtree() > > The revert needs to get into v5.4. Maybe Richard has forget about it ? I hit this today. The error I saw was: [ 4.975868] jffs2: error: (77) jffs2_build_inode_fragtree: Add node to tree failed -22 [ 4.983923] jffs2: error: (77) jffs2_do_read_inode_internal: Failed to build final fragtree for inode #5377: error -22 [ 4.994709] jffs2: Returned error for crccheck of ino #5377. Expect badness... Reverting the f2538f999345 commit fixed things. Is the revert queued for stable? Cheers, Joel