Hi, Randy On 2019/11/27 下午12:58, Randy Dunlap wrote: > On 11/26/19 5:50 PM, 王贇 wrote: >> Since v1: >> * thanks to Iurii for the better sentence >> * thanks to Jonathan for the better format >> >> Add the description for 'cg_numa_stat', also a new doc to explain >> the details on how to deal with the per-cgroup numa statistics. >> >> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> >> Cc: Michal Koutný <mkoutny@xxxxxxxx> >> Cc: Mel Gorman <mgorman@xxxxxxx> >> Cc: Jonathan Corbet <corbet@xxxxxxx> >> Cc: Iurii Zaikin <yzaikin@xxxxxxxxxx> >> Signed-off-by: Michael Wang <yun.wang@xxxxxxxxxxxxxxxxx> > > Hi, > I have a few comments/corrections. Please see below. Thanks for the comments :-) will apply them all in next version. > >> --- >> Documentation/admin-guide/cg-numa-stat.rst | 163 [snip] >> +if you want to have the whole history. >> + >> +We have per-task migfailed counter to tell how many page migration has been > > I can't find any occurrence of 'migfailed' in the entire kernel source tree. > Maybe it is misspelled? This one is added by the secondary patch: [PATCH v2 2/3] sched/numa: expose per-task pages-migration-failure As suggested by Mel. Regards, Michael Wang > >> +failed for a particular task, you will find it in /proc/PID/sched entry. > > > HTH. >