Hi Carlos, Thank you for the patch! Yet something to improve: [auto build test ERROR on hch-configfs/for-next] [also build test ERROR on v5.4-rc8 next-20191122] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Carlos-Maiolino/Refactor-ioctl_fibmap-internal-interface/20191124-165458 base: git://git.infradead.org/users/hch/configfs.git for-next config: riscv-allnoconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from fs/inode.c:7:0: include/linux/fs.h: In function 'bmap': include/linux/fs.h:2869:31: error: parameter name omitted static inline int bmap(struct inode *, sector_t *) ^~~~~ include/linux/fs.h:2869:31: error: parameter name omitted fs/inode.c: At top level: >> fs/inode.c:1608:5: error: redefinition of 'bmap' int bmap(struct inode *inode, sector_t *block) ^~~~ In file included from fs/inode.c:7:0: include/linux/fs.h:2869:19: note: previous definition of 'bmap' was here static inline int bmap(struct inode *, sector_t *) ^~~~ vim +/bmap +1608 fs/inode.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 1593 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1594 /** ^1da177e4c3f41 Linus Torvalds 2005-04-16 1595 * bmap - find a block number in a file 1dc338a4af8188 Carlos Maiolino 2019-11-22 1596 * @inode: inode owning the block number being requested 1dc338a4af8188 Carlos Maiolino 2019-11-22 1597 * @block: pointer containing the block to find ^1da177e4c3f41 Linus Torvalds 2005-04-16 1598 * 1dc338a4af8188 Carlos Maiolino 2019-11-22 1599 * Replaces the value in *block with the block number on the device holding 1dc338a4af8188 Carlos Maiolino 2019-11-22 1600 * corresponding to the requested block number in the file. 1dc338a4af8188 Carlos Maiolino 2019-11-22 1601 * That is, asked for block 4 of inode 1 the function will replace the 1dc338a4af8188 Carlos Maiolino 2019-11-22 1602 * 4 in *block, with disk block relative to the disk start that holds that 1dc338a4af8188 Carlos Maiolino 2019-11-22 1603 * block of the file. 1dc338a4af8188 Carlos Maiolino 2019-11-22 1604 * 1dc338a4af8188 Carlos Maiolino 2019-11-22 1605 * Returns -EINVAL in case of error, 0 otherwise. If mapping falls into a 1dc338a4af8188 Carlos Maiolino 2019-11-22 1606 * hole, returns 0 and *block is also set to 0. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1607 */ 1dc338a4af8188 Carlos Maiolino 2019-11-22 @1608 int bmap(struct inode *inode, sector_t *block) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1609 { 1dc338a4af8188 Carlos Maiolino 2019-11-22 1610 if (!inode->i_mapping->a_ops->bmap) 1dc338a4af8188 Carlos Maiolino 2019-11-22 1611 return -EINVAL; 1dc338a4af8188 Carlos Maiolino 2019-11-22 1612 1dc338a4af8188 Carlos Maiolino 2019-11-22 1613 *block = inode->i_mapping->a_ops->bmap(inode->i_mapping, *block); 1dc338a4af8188 Carlos Maiolino 2019-11-22 1614 return 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1615 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1616 EXPORT_SYMBOL(bmap); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1617 :::::: The code at line 1608 was first introduced by commit :::::: 1dc338a4af818855d7878307b8026c6af9e6304a fs: Enable bmap() function to properly return errors :::::: TO: Carlos Maiolino <cmaiolino@xxxxxxxxxx> :::::: CC: 0day robot <lkp@xxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation
Attachment:
.config.gz
Description: application/gzip