On Fri, Nov 22, 2019 at 02:37:01PM +0100, Christoph Hellwig wrote: > On Fri, Nov 22, 2019 at 09:53:16AM +0100, Carlos Maiolino wrote: > > By now, bmap() will either return the physical block number related to > > the requested file offset or 0 in case of error or the requested offset > > maps into a hole. > > This patch makes the needed changes to enable bmap() to proper return > > errors, using the return value as an error return, and now, a pointer > > must be passed to bmap() to be filled with the mapped physical block. > > > > It will change the behavior of bmap() on return: > > > > - negative value in case of error > > - zero on success or map fell into a hole > > > > In case of a hole, the *block will be zero too > > > > Since this is a prep patch, by now, the only error return is -EINVAL if > > ->bmap doesn't exist. > > > > Changelog: > > > > V6: > > - Fix bmap() doc function > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > V5: > > - Rebasing against 5.3 required changes to the f2fs > > check_swap_activate() function > > > > Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > > --- > > The changelog goes under the --- if you really want a per-patch > changelog. I personally find the per-patch changelog horribly > distracting and much prefer just one in the cover letter, though. > > Otherwise this looks good, although we really need to kill these > users rather sooner than later.. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Yeah, I forgot to move the changelogs under --- while formatting the patches, I didn't mean to send them on the commit log. This signed-off-by was meant to be a reviewed-by? I'm not sure if I got what you meant with the sign-off here. -- Carlos
