On Thu, Nov 21, 2019 at 03:55:28PM -0800, Darrick J. Wong wrote:
> On Thu, Nov 21, 2019 at 05:15:34PM +0100, Jan Kara wrote:
> > @@ -497,8 +497,15 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
> > }
> > pos += ret;
> >
> > - if (iov_iter_rw(iter) == READ && pos >= dio->i_size)
> > + if (iov_iter_rw(iter) == READ && pos >= dio->i_size) {
> > + /*
> > + * We will report we've read data only upto i_size.
>
> Nit: "up to"; will fix that on the way in.
A nit of a nit: "We will report that we've read..."; I think it reads
better, so might as well update it if you're already fixing the other
nit up as you're pulling this in. :P
/M
