> > + exfat_msg(sb, KERN_ERR, > > + "failed to load upcase table (idx : 0x%08x, chksum : > 0x%08x, utbl_chksum : 0x%08x)\n", > > + index, checksum, utbl_checksum); > > + > > + ret = -EINVAL; > > Can a blank line be omitted between the message and the error code? Okay. > > > > +release_bh: > > + brelse(bh); > > + exfat_free_upcase_table(sb); > > + return ret; > > +} > > I got the impression that the resource management is still questionable > for this function implementation. > > 1. Now I suggest to move the call of the function “brelse” to the end > of the while loop. The label “release_bh” would be renamed to “free_table” > then. Okay. > > 2. Can a variable initialisation be converted to the assignment “ret = -EIO;” > in an if branch? Okay, Will fix it on v5. Thanks for your review! > > Regards, > Markus
