On Wed, Nov 20, 2019 at 11:13:36PM -0800, John Hubbard wrote: > +static int pin_goldfish_pages(unsigned long first_page, > + unsigned long last_page, > + unsigned int last_page_size, > + int is_write, > + struct page *pages[MAX_BUFFERS_PER_COMMAND], > + unsigned int *iter_last_page_size) Why not goldfish_pin_pages? Normally we put the module / subsystem in front. Also can we get this queued up for 5.5 to get some trivial changes out of the way?