RE: [PATCH v2 05/13] exfat: add file operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Thu, 21 Nov 2019 10:42:13 +0900, "Namjae Jeon" said:
> 
> > > > +		if (clu.flags == 0x03) {
> > >
> > > That 0x03 is magic constant, better define actual flags and check
> > > clu.flag == (FLAG1|FLAG2)
> > Okay, Will fix it on v4.
> 
> Make sure you catch all the cases.  I seem to remember a lot of 0x01's
> in the code as well....
Yes, I know.
Thanks!




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux