Re: [PATCH v3 10/13] exfat: add nls operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> …
>>> +++ b/fs/exfat/nls.c
>> …
>>> +static int exfat_load_upcase_table(struct super_block *sb,
>>> +		sector_t sector, unsigned long long num_sectors,
>>> +		unsigned int utbl_checksum)
>>> +{
>> …
>>> +error:
>>> +	if (bh)
>>> +		brelse(bh);
…
>> Can the label “release_bh” be more helpful?
…
> I checked not only review point but also your review points in
> other patches, I will fix them on v4.
…

Another software design alternative would be to use a jump target
like “free_table” instead at this source code place, wouldn't it?

Regards,
Markus




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux