On 11/18/19 2:16 AM, Jan Kara wrote: > On Thu 14-11-19 21:53:26, John Hubbard wrote: >> /* >> - * NOTE on FOLL_LONGTERM: >> + * FOLL_PIN and FOLL_LONGTERM may be used in various combinations with each >> + * other. Here is what they mean, and how to use them: >> * >> * FOLL_LONGTERM indicates that the page will be held for an indefinite time >> - * period _often_ under userspace control. This is contrasted with >> - * iov_iter_get_pages() where usages which are transient. >> + * period _often_ under userspace control. This is in contrast to >> + * iov_iter_get_pages(), where usages which are transient. > ^^^ when you touch this, please fix also the > second sentense. It doesn't quite make sense to me... I'd probably write > there "whose usages are transient" but maybe you can come up with something > even better. Fixed, using your wording, as I didn't see any obvious improvements beyond that. thanks, -- John Hubbard NVIDIA > > Otherwise the patch looks good to me so feel free to add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > Honza >
