On 8:47 15/11, Christoph Hellwig wrote: > The subject is a little odd, as we only optionally override submit_bio. > Maybe something like: > > iomap: add a file system hook for direct I/O bio submission > > On Fri, Nov 15, 2019 at 10:16:56AM -0600, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> > > > > This helps filesystems to perform tasks on the bio while > > submitting for I/O. This could be post-write operations > > such as data CRC or data replication for fs-handled RAID. > > You can use up to 73 chars for the commit log. > > > + if (dio->dops && dio->dops->submit_io) > > + dio->submit.cookie = dio->dops->submit_io(bio, > > + file_inode(dio->iocb->ki_filp), pos); > > Any reason to not simply pass the file? No, I just didn't change the original btrfs_submit_direct(). Passing filp will be much neater. I will incorporate this. I agree with all of your comments, and will implement them in the next patchset. -- Goldwyn
