On 11/12/19 12:44 PM, Jason Gunthorpe wrote: > On Mon, Nov 11, 2019 at 04:06:48PM -0800, John Hubbard wrote: >> @@ -542,7 +541,7 @@ static int ib_umem_odp_map_dma_single_page( >> } >> >> out: >> - put_user_page(page); >> + put_page(page); >> >> if (remove_existing_mapping) { >> ib_umem_notifier_start_account(umem_odp); >> @@ -639,13 +638,14 @@ int ib_umem_odp_map_dma_pages(struct ib_umem_odp *umem_odp, u64 user_virt, >> /* >> * Note: this might result in redundent page getting. We can >> * avoid this by checking dma_list to be 0 before calling >> - * get_user_pages. However, this make the code much more >> - * complex (and doesn't gain us much performance in most use >> - * cases). >> + * get_user_pages. However, this makes the code much >> + * more complex (and doesn't gain us much performance in most >> + * use cases). >> */ >> npages = get_user_pages_remote(owning_process, owning_mm, >> - user_virt, gup_num_pages, >> - flags, local_page_list, NULL, NULL); >> + user_virt, gup_num_pages, >> + flags, local_page_list, NULL, >> + NULL); >> up_read(&owning_mm->mmap_sem); > > This is just whitespace churn? Drop it.. > Whoops, yes. It got there because of going through the pin*() conversion and then a revert, and now it's just whitespace. I'll drop it, thanks for catching that. thanks, John Hubbard NVIDIA