> > On Mon, Nov 11, 2019 at 04:34:52PM -0800, ira.weiny@xxxxxxxxx wrote: > > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > swap_activate() and swap_deactivate() have nothing to do with address > > spaces. We want to eventually make the address space operations > > dynamic to switch inode flags on the fly. So to simplify this code as > > well as properly track these operations we move these functions to the > > file_operations vector. > > What is the point? If we switch aops for DAX vs not we might as well switch > file operations as well, as they pretty much are entirely different. Obviously I was not clear enough. The point is to have 2 fewer a_ops functions to worry about synchronizing. I see Jan already replied. So I'll leave it at that. Ira