On Wed, Nov 06, 2019 at 08:04:00PM +0100, Andreas Gruenbacher wrote: > On architectures where ssize_t is wider than pgoff_t, the expression > ((page->index + 1) << PAGE_SHIFT) can overflow. Rewrite to use the page > offset, which we already compute here anyway. > > Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx> Looks good except for the ssize_t vs loff_t in the changelog: Reviewed-by: Christoph Hellwig <hch@xxxxxx>