On Wed, Nov 6, 2019 at 8:17 PM Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: > On Wed, Nov 06, 2019 at 08:04:00PM +0100, Andreas Gruenbacher wrote: > > On architectures where ssize_t is wider than pgoff_t, the expression > > ssize_t? But you're changing @offset, which is loff_t. I'm confused. Oops, should have been loff_t instead of ssize_t. > Also, which architectures are you talking about here? >From the kernel headers: #define pgoff_t unsigned long typedef long long __kernel_loff_t; typedef __kernel_loff_t loff_t; So for example, sizeof(loff_t) > sizeof(pgoff_t) on x86. Thanks, Andreas
