On 11/4/19 12:31 PM, Jason Gunthorpe wrote: > On Mon, Nov 04, 2019 at 12:09:05PM -0800, John Hubbard wrote: > >> Note for Jason: the (a) or (b) items are talking about the vfio case, which is >> one of the two call sites that now use pin_longterm_pages_remote(), and the >> other one is infiniband: >> >> drivers/infiniband/core/umem_odp.c:646: npages = pin_longterm_pages_remote(owning_process, owning_mm, > > This is a mistake, it is not a longterm pin and does not need FOLL_PIN > semantics OK! So it really just wants to be get_user_pages_remote() / put_page()? I'll change it back to that. > >> Jason should weigh in on how he wants this to go, with respect to branching >> and merging, since it sounds like that will conflict with the hmm branch > > I think since you don't need to change this site things should be > fine? > Right. thanks, John Hubbard NVIDIA