On Mon, Nov 04, 2019 at 05:53:55AM -0500, Valdis Klētnieks wrote:
> On Mon, 04 Nov 2019 13:04:14 +0300, Dan Carpenter said:
> > On Sun, Nov 03, 2019 at 08:45:03PM -0500, Valdis Kletnieks wrote:
> > > - if (sector_read(sb, sec, &bp->buf_bh, 1) != FFS_SUCCESS) {
> > > + if (sector_read(sb, sec, &bp->buf_bh, 1) != 0) {
> >
> > It's better to just remove the "!= 0" double negative. != 0 should be
> > used when we are talking about the number zero as in "cnt != 0" and for
> > "strcmp(foo, bar) != 0" where it means that "foo != bar".
>
> "Fix up ==0 and !=0" is indeed on the to-do list.
>
> This patch converted 82 uses of FFS_SUCCESS, of which 33 had the != idiom in
> use. Meanwhile, overall there's 53 '!= 0' and 95 '== 0' uses.
>
> In other words, even if I fixed all of those that were involved in this patch,
> there would *still* be more patching to do.
Very good. Sounds like the plan.
regards,
dan carpenter
