On Tue, 2019-10-29 at 13:53 +0000, Al Viro wrote: > [resent to correct address] > > we should not play with dcache without parent locked... > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c > index 9f135624ae47..c07407586ce8 100644 > --- a/fs/ceph/inode.c > +++ b/fs/ceph/inode.c > @@ -1434,6 +1434,7 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req) > dout(" final dn %p\n", dn); > } else if ((req->r_op == CEPH_MDS_OP_LOOKUPSNAP || > req->r_op == CEPH_MDS_OP_MKSNAP) && > + test_bit(CEPH_MDS_R_PARENT_LOCKED, &req->r_req_flags) && > !test_bit(CEPH_MDS_R_ABORTED, &req->r_req_flags)) { > struct inode *dir = req->r_parent; > Thanks Al. Both patches merged and marked for stable. Ilya should send a PR to Linus with these within the next week or so. -- Jeff Layton <jlayton@xxxxxxxxxx>