On Fri, Oct 25, 2019 at 11:50:05AM +0200, Christoph Hellwig wrote:
> On Thu, Oct 24, 2019 at 10:44:52PM -0700, Darrick J. Wong wrote:
> > > case XFS_IOC_FREESP:
> > > - case XFS_IOC_UNRESVSP:
> > > case XFS_IOC_ALLOCSP64:
> > > - case XFS_IOC_FREESP64:
> > > - case XFS_IOC_UNRESVSP64:
> > > - case XFS_IOC_ZERO_RANGE: {
> > > + case XFS_IOC_FREESP64: {
> >
> > Ok, so this hoists everything to the vfs except for ALLOCSP and FREESP,
> > which seems to be ... "set new size; allocate between old and new EOF if
> > appropriate"?
> >
> > I'm asking because I was never really clear on what those things are
> > supposed to do. :)
>
> Yes. ALLOCSP/FREESP have so weird semantics that we never added the
> equivalent functionality to fallocate.
We should plan to deprecate and remove ALLOCSP/FREESP - they just
aren't useful APIs anymore, and nobody has used them in preference
to the RESVSP/UNRESVSP ioctls since they were introduced in ~1998
with unwritten extents. We probably should have deprecated then 10
years ago....
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
