On Wed, Oct 23, 2019 at 01:27:44AM -0400, Valdis Kletnieks wrote: > Make as much as possible static. We're over-exuberant here for the benefit > of a following patch, as the compiler will flag now-unused static code This adds a bunch of compiler warnings, which isn't ok. Please fix this up to be correct and not add build warnings, as it just hides real issues. I'll drop this series and wait for a new version with this fixed up. thanks, greg k-h