On Wed, Oct 23, 2019 at 12:01:51PM +0530, Ritesh Harjani wrote: > > > On 10/21/19 2:47 PM, Matthew Bobrowski wrote: > > Separate the iomap field population chunk of code that is currently > > within ext4_iomap_begin() into a new helper called > > ext4_set_iomap(). The intent of this function is self explanatory, > > however the rationale behind doing so is to also reduce the overall > > clutter that we currently have within the ext4_iomap_begin() callback. > > > > Signed-off-by: Matthew Bobrowski <mbobrowski@xxxxxxxxxxxxxx> > > Could you please re-arrange patch sequence in this fashion. > > 1. Patch-11 (re-ordering of unwritten flags) > 2. Patch-8 (trylock in IOCB_NOWAIT cases) > 3. Patch-2 (should explain offset & len in this patch) > 4. Patch-1 (this patch). No objections to this. Just needing to do a little shuffle here and there. > This is so that some of these are anyway fixes or refactoring > which can be picked up easily, either for backporting or > sometimes this helps in getting some of the patches in, if the patch > series gets bigger. > Also others (like me) can also pick some of these changes then to meet > their dependency. :) Sure, thanks for educating me and making me aware of this. > This patch looks good to me. You may add: > > Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx> Thanks Ritesh! --<M>--
