On May 28, 2008 11:31 -0400, Josef Bacik wrote:
> +int generic_block_fiemap(struct inode *inode,
> + struct fiemap_extent_info *fieinfo, u64 start,
> + u64 len, get_block_t *get_block)
> +{
This still doesn't do any validity checking on fieinfo->fi_flags. You
can't assume that the check in ioctl_fiemap() is correct for this routine.
As soon as some new flag is added (e.g. FIEMAP_FLAG_XATTR) this code would
do the wrong thing.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
