On Tue, Oct 22, 2019 at 12:26:09PM +0200, Arnd Bergmann wrote: > On Tue, Oct 22, 2019 at 6:34 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote: > > > Each of these drivers has a copy of the same trivial helper function to > > > convert the pointer argument and then call the native ioctl handler. > > > > > > We now have a generic implementation of that, so use it. > > > > I'd rather flipped your #7 (ceph_compat_ioctl() introduction) past > > that one... > > The idea was to be able to backport the ceph patch as a bugfix > to stable kernels without having to change it or backport > compat_ptr_ioctl() as well. > > If you still prefer it that way, I'd move to a simpler version of this > patch and drop the Cc:stable. What I'm going to do is to put the introduction of compat_ptr_ioctl() into a never-rebased branch; having e.g. ceph patch done on top of it should suffice - it can go into -stable just fine. Trivially backported all the way back, has no prereqs and is guaranteed to cause no conflicts, so if any -stable fodder ends up depending upon it, there will be no problem whatsoever. IMO that commit should precede everything else in the queue... Another thing is that I'd fold #8 into #6 - it clearly belongs in there.
