On Tue 22-10-19 13:04:21, Matthew Bobrowski wrote: > On Mon, Oct 21, 2019 at 03:48:17PM +0200, Jan Kara wrote: > > On Mon 21-10-19 20:18:46, Matthew Bobrowski wrote: > > > This patch updates the lock pattern in ext4_dio_read_iter() to only > > > perform the trylock in IOCB_NOWAIT cases. > > > > The changelog is actually misleading. It should say something like "This > > patch updates the lock pattern in ext4_dio_read_iter() to not block on > > inode lock in case of IOCB_NOWAIT direct IO reads." > > > > Also to ease backporting of easy fixes, we try to put patches like this > > early in the series (fixing code in ext4_direct_IO_read(), and then the > > fixed code would just carry over to ext4_dio_read_iter()). > > OK, understood. Now I know this for next time. :) > > Providing that I have this patch precede the ext4_dio_read_iter() > patch and implement this lock pattern in ext4_direct_IO_read(), am I > OK to add the 'Reviewed-by' tag? Yes. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
