On Mon 21-10-19 20:18:09, Matthew Bobrowski wrote:
> As part of the ext4_iomap_begin() cleanups that precede this patch,
> here we also split up the IOMAP_REPORT branch into a completely
> separate ->iomap_begin() callback named
> ext4_iomap_begin_report(). Again, the raionale for this change is to
> reduce the overall clutter that's starting to become apparent as we
> start to port more functionality over to the iomap infrastructure.
>
> Signed-off-by: Matthew Bobrowski <mbobrowski@xxxxxxxxxxxxxx>
The patch looks good to me. You can add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
One nit below.
> + ext4_es_find_extent_range(inode, &ext4_es_is_delayed,
> + map->m_lblk, end, &es);
> +
> + if (!es.es_len || es.es_lblk > end)
> + return false;
> +
> + if (es.es_lblk > map->m_lblk) {
> + map->m_len = es.es_lblk - map->m_lblk;
> + return false;
> + }
> +
> + if (es.es_lblk <= map->m_lblk)
This condition must be always true AFAICT.
> + offset = map->m_lblk - es.es_lblk;
> +
> + map->m_lblk = es.es_lblk + offset;
> + map->m_len = es.es_len - offset;
> +
> + return true;
> +}
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
