On Tue, Oct 15, 2019 at 10:27:13PM -0700, Darrick J. Wong wrote: > > + /* > > + * Writes that span EOF might trigger an IO size update on completion, > > + * so consider them to be dirty for the purposes of O_DSYNC even if > > + * there is no other metadata changes being made or are pending here. > > + */ > > + if (offset + count > i_size_read(inode)) > > + iomap->flags |= IOMAP_F_DIRTY; > > This ought to be in xfs_direct_write_iomap_begin(), right? > > (Hoping to see another rev of Christoph's iomap cleanup series... ;)) I need to finish off all the nitpicks on the first iomap series.. Also we'll want this patch in first as it is 5.4 / -stable material, so I'll need to rebase on top of that as well.
