On Tue, Oct 15, 2019 at 05:43:43PM +0200, Christoph Hellwig wrote: > And inline mapping should never mark the page dirty and thus never end up > in writepages. Add a check for that condition and warn if it happens. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/iomap/buffered-io.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 00af08006cd3..76e72576f307 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -1421,6 +1421,8 @@ iomap_writepage_map(struct iomap_writepage_ctx *wpc, > error = wpc->ops->map_blocks(wpc, inode, file_offset); > if (error) > break; > + if (WARN_ON_ONCE(wpc->iomap.type == IOMAP_INLINE)) > + continue; > if (wpc->iomap.type == IOMAP_HOLE) > continue; > iomap_add_to_ioend(inode, file_offset, page, iop, wpc, wbc, looks fine. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
