On Fri, Oct 11, 2019 at 02:18:26PM -0400, Vivek Goyal wrote: > We have been calling it virtio_fs and even file name is virtio_fs.c. Module > name is virtio_fs.ko but when registering file system user is supposed to > specify filesystem type as "virtiofs". > > Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and > got this warning on console. > > ------------[ cut here ]------------ > request_module fs-virtio_fs succeeded, but still no fs? > WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138 > Modules linked in: ... virtio_fs fuse virtio_net net_failover ... > CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1 > > So looks like kernel could find the module virtio_fs.ko but could not find > filesystem type after that. > > It probably is better to rename module name to virtiofs.ko so that above > warning goes away in case user ends up specifying wrong fs name. > > Reported-by: Masayoshi Mizuma <msys.mizuma@xxxxxxxxx> > Suggested-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx> > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx> > --- > fs/fuse/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: rhvgoyal-linux/fs/fuse/Makefile > =================================================================== > --- rhvgoyal-linux.orig/fs/fuse/Makefile 2019-10-11 13:53:43.905757435 -0400 > +++ rhvgoyal-linux/fs/fuse/Makefile 2019-10-11 13:54:24.147757435 -0400 > @@ -5,6 +5,7 @@ > > obj-$(CONFIG_FUSE_FS) += fuse.o > obj-$(CONFIG_CUSE) += cuse.o > -obj-$(CONFIG_VIRTIO_FS) += virtio_fs.o > +obj-$(CONFIG_VIRTIO_FS) += virtiofs.o > > fuse-objs := dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o > +virtiofs-y += virtio_fs.o Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
