On Sun, May 25, 2008 at 01:40:48AM -0600, Andreas Dilger wrote:
> On May 24, 2008 17:02 -0700, Mark Fasheh wrote:
> > +int ocfs2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
> > + u64 map_start, u64 map_len)
> > +{
> > + int ret, is_last;
> > + u32 mapping_end, cpos;
> > + unsigned int hole_size;
> > + struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
> > + u64 len_bytes, phys_bytes, virt_bytes;
> > + struct buffer_head *di_bh = NULL;
> > + struct ocfs2_extent_rec rec;
> > +
> > + if (fieinfo->fi_flags & FIEMAP_FLAG_XATTR) {
> > + fieinfo->fi_flags = FIEMAP_FLAG_XATTR;
> > + return -EBADR;
> > + }
>
> This actually needs to check for every flag it DOES understand, otherwise
> it would break as soon as a new flag is added, per my comment in the VFS
> patch email.
Yeah, the feature checks in the existing per-fs patches are lacking. This
will be fixed in the next round.
--Mark
--
Mark Fasheh
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
