On Wed 09-10-19 12:19:59, David Hildenbrand wrote: [...] > > pfn_to_online_page makes sense because offline pages are not really in a > > defined state. This would be worth a patch of its own. I remember there > > The issue is, once I check for pfn_to_online_page(), these functions > can't handle ZONE_DEVICE at all anymore. Especially in regards to > memory_failure() I don't think this is acceptable. Could you be more specific please? I am not sure I am following. > So while I > (personally) only care about adding pfn_to_online_page() checks, the > in-this-sense-fragile-subsection ZONE_DEVICE implementation requires me > to introduce a temporary check for initialized memmaps. > > > was a discussion about the uninitialized zone device memmaps. It would > > be really good to summarize this discussion in the changelog and > > conclude why the explicit check is really good and what were other > > alternatives considered. > > Yeah, I also expressed my feelings and the issues to be solved by > ZONE_DEVICE people in https://lkml.org/lkml/2019/9/6/114. However, the > discussion stalled and nobody really proposed a solution or followed up. I will try to get back to that discussion but is there any technical reason that prevents any conclusion or it is just stuck on a lack of time of the participants? -- Michal Hocko SUSE Labs
