On Wed, Oct 09, 2019 at 11:57:04AM +0530, Ritesh Harjani wrote: > On 10/3/19 5:04 PM, Matthew Bobrowski wrote: > > In preparation for implementing the iomap direct I/O write path > > modifications, the inode extension/truncate code needs to be moved out > > from ext4_iomap_end(). For direct I/O, if the current code remained > > within ext4_iomap_end() it would behave incorrectly. Updating the > > inode size prior to converting unwritten extents to written extents > > will potentially allow a racing direct I/O read operation to find > > unwritten extents before they've been correctly converted. > > > > The inode extension/truncate code has been moved out into a new helper > > ext4_handle_inode_extension(). This function has been designed so that > > it can be used by both DAX and direct I/O paths. > > > > Signed-off-by: Matthew Bobrowski <mbobrowski@xxxxxxxxxxxxxx> > > checkpatch shows some whitespaces error in your comments > in this patch. > But apart from that, patch looks good to me. Yeah, I will fix those. > You may add: > > Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx> Thanks! --<M>--
