Chris Mason wrote: > On Sunday 25 May 2008, Christoph Hellwig wrote: > > Thanks for doing this Mark ;) > >> On Sat, May 24, 2008 at 05:01:48PM -0700, Mark Fasheh wrote: >>> * FIEMAP_FLAG_HSM_READ >>> If the extent is offline, retrieve it before mapping and do not flag >>> it as FIEMAP_EXTENT_SECONDARY. This flag has no effect if the file >>> system does not support HSM. >> Given that there's no HSM support in mainline this should not be added. >> It'll be useful once we add proper HSM support, though :) >> > > The HSM flag doesn't hurt, and it allows the people actually shipping hsm > patches to use fiemap without extending the api themselves. Reserving the > flag isn't a bad idea. Here I agree. HSM is a generic enough concept, and I think this interface's API w.r.t. HSM is well-enough defined that there's no reason not to go ahead & put it in now, IMHO. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
