On Tue, Oct 08, 2019 at 05:57:12AM +0100, Al Viro wrote: > > OK... BTW, do you agree that the use of access_ok() in > drivers/tty/n_hdlc.c:n_hdlc_tty_read() is wrong? It's used as an early > cutoff, so we don't bother waiting if user has passed an obviously bogus > address. copy_to_user() is used for actual copying there... Yes, it's wrong, and not needed. I'll go rip it out unless you want to? thanks, greg k-h
