Thanks David, On Wed, Oct 2, 2019 at 4:22 AM David Sterba <dsterba@xxxxxxx> wrote: > > On Mon, Sep 30, 2019 at 04:01:10PM -0500, Navid Emamdoost wrote: > > In affs_remount if data is provided it is duplicated into new_opts. > > The allocated memory for new_opts is only released if pare_options fail. > > The release for new_opts is added. > > A variable that is allocated and freed without use should ring a bell to > look closer at the code. There's a bit of history behind new_options, > originally there was save/replace options on the VFS layer so the 'data' > passed must not change (thus strdup), this got cleaned up in later > patches. But not completely. > > There's no reason to do the strdup in cases where the filesystem does > not need to reuse the 'data' again, because strsep would modify it > directly. > > So new_opts should be removed. I will send a new patch with the unused variable removed. -- Navid.
