Hi Markus, thanks for your suggestions for improving the quality of the patch. At the moment I prefer first get a confirmation from contributors about the leak and then work on any possible improvements for the patch. Thanks, Navid. On Tue, Oct 1, 2019 at 3:31 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote: > > > The allocated memory for new_opts is only released if pare_options fail. > > Can the following wording be nicer? > > The allocated memory for the buffer “new_opts” will be released > only if a call of the function “parse_options” failed. > > > > The release for new_opts is added. > > * How do you think about the change possibility to delete questionable > source code here? > > * Would you like to complete the data processing for corresponding options > any more? > > > > -- fix a type in title, … > > Please avoid typos also in your version comments. > > > > --- > > I suggest to replace this second delimiter by a blank line. > > Regards, > Markus -- Navid.
