On Thu, Sep 26, 2019 at 11:56:30AM +0200, Jens Axboe wrote: > On 9/26/19 11:50 AM, Colin King wrote: > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > > > In the case where sig is NULL the error variable ret is not initialized > > and may contain a garbage value on the final checks to see if ret is > > -ERESTARTSYS. Best to initialize ret to zero before the do loop to > > ensure the ret does not accidentially contain -ERESTARTSYS before the > > loop. > > Oops, weird it didn't complain. I've folded in this fix, as that commit > isn't upstream yet. Thanks! There is a bug in GCC where at certain optimization levels, instead of complaining, it initializes it to zero. regards, dan carpenter
