On Fri, May 23, 2008 at 11:15:19AM +0900, Kentaro Makita wrote: > Hi, David > > Thank you for reviewing the patch. > I'd fix coding style issues at next post. And,... > > David Chinner wrote: > > On Thu, May 22, 2008 at 11:22:18AM +0900, Kentaro Makita wrote: > >> + } > >> + } > >> + } > > > > I'm wondering if this loop is an excessively long time to be holding the > > dcache_lock. I guess the hol dtime is limited by the size of *count being > > passed in. I think we could also do a: > > > > cond_resched_lock(&dcache_lock); > > > > in the loop here to prevent this from occurring.... > Did you mean: > - scan sb->s_dentry_lru and move dentries to temporary list > with lock held > - cond_resched_lock(&dcache_lock); > - prune dentries on temporary list > Is that right? No, I meant while scanning sb->s_dentry_lru. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
