[add dave to cc] On Wed, Sep 18, 2019 at 04:49:24PM -0700, Matthew Wilcox wrote: > On Wed, Sep 18, 2019 at 02:17:55PM -0700, Darrick J. Wong wrote: > > On Tue, Aug 20, 2019 at 05:30:36PM -0700, Matthew Wilcox wrote: > > > From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> > > > > > > The page_offset function is badly named for people reading the functions > > > which call it. The natural meaning of a function with this name would > > > be 'offset within a page', not 'page offset in bytes within a file'. > > > Dave Chinner suggests file_offset_of_page() as a replacement function > > > name and I'm also adding file_offset_of_next_page() as a helper for the > > > large page work. Also add kernel-doc for these functions so they show > > > up in the kernel API book. > > > > > > page_offset() is retained as a compatibility define for now. > > > > No SOB? > > > > Looks fine to me, and I appreciate the much less confusing name. I was > > hoping for a page_offset conversion for fs/iomap/ (and not a treewide > > change because yuck), but I guess that can be done if and when this > > lands. > > Sure, I'll do that once everything else has landed. You might also want to ask Dave Chinner what changes he's making to iomap to support blocksize > pagesize filesystems, since that's /definitely/ going to clash. :) --D
