On Mon, Sep 09, 2019 at 08:27:11PM +0200, Christoph Hellwig wrote: > There is no reason not to punch out stale delalloc blocks for zeroing > operations, as they otherwise behave exactly like normal writes. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > --- > fs/xfs/xfs_iomap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c > index f1c3ff27c666..db4764c16142 100644 > --- a/fs/xfs/xfs_iomap.c > +++ b/fs/xfs/xfs_iomap.c > @@ -1138,7 +1138,8 @@ xfs_file_iomap_end( > unsigned flags, > struct iomap *iomap) > { > - if ((flags & IOMAP_WRITE) && iomap->type == IOMAP_DELALLOC) > + if ((flags & (IOMAP_WRITE | IOMAP_ZERO)) && > + iomap->type == IOMAP_DELALLOC) > return xfs_file_iomap_end_delalloc(XFS_I(inode), offset, > length, written, iomap); > return 0; > -- > 2.20.1 >