On Wed, Sep 18, 2019 at 2:57 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > Overall this looks ok to me. Handling full vq by a timer is really gross > but it's correct - just terribly inefficient. Yes. The reason this didn't get too much attention is that it's relatively difficult to make the queues actually fill up (which is a good thing). But this should definitely be one of the first things to be cleaned up... > I think you should add a > MAINTAINERS entry though, we want > virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx Cc'd on patches. Already done in the documentation patch (which I didn't resend, but you should find the v5 version in your mailbox). > With that corrected: > > Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > Who's going to merge this? Miklos do you want to merge it yourself? I'll merge this since it depends on the rest of the fuse queue. > > + /** > > + * Cleanup up when fuse_iqueue is destroyed > > Cleanup up -> Clean up Fixed. > > + * virtio-fs: Virtio Filesystem > > + * Copyright (C) 2018 Red Hat, Inc. > > > 2019 at this point? I'd consider the creation year okay for this. These copyright notices don't seem to be kept up to date, and don't need to, since the SOB procedure allows for fine-grained tracking of authorship. > > + /* After holding mutex, make sure virtiofs device is still there. > > + * Though we are holding a refernce to it, drive ->remove might > > refernce -> reference Fixed. Changes, with your ack pushed to: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next Thanks, Miklos
