On Wed, Sep 11, 2019 at 4:53 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > On Tue, Sep 10, 2019 at 05:12:02PM +0200, Miklos Szeredi wrote: > > Git tree for this version is available here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v5 > > > > Only post patches that actually add virtiofs (virtiofs-v5-base..virtiofs-v5). > > > > I've folded the series from Vivek and fixed a couple of TODO comments > > myself. AFAICS two issues remain that need to be resolved in the short > > term, one way or the other: freeze/restore and full virtqueue. > > Hi Miklos, > > We are already handling full virtqueue by waiting a bit and retrying. > I think TODO in virtio_fs_enqueue_req() is stale. Caller already > handles virtqueue full situation by retrying. Ah. > > Havind said that, this could be improved by using some sort of wait > queue or completion privimitve. Yeah, the request queuing can be cleaned up in several ways. But I think that we might postpone that till after merging with mainline. Thanks, Miklos
